NOTE #2041

The following line was commented.

Description

This EWI appears if for some reason the line can cause compilation errors and therefore the migration tool decides to commented out.

This can have due to several reasons, for example:

Foreach Variable Assignment in C#
API Calls are moved to another file

Foreach Variable in C# generated code

In C# a foreach variable can't be assignable, so to avoid a compilation error, the line must be commented. In VB.Net the iteration variable can be assigned so, this restriction is not applied.

Recommendations

Check the logic of the original VB6 function. In some cases the nothing assignation to the iteration variable is a way to stop the cycle. If this is the case use the break statement instead.

For the given example, just remove the commented line and the EWI.

Sample VB6

Public Function TestCommentedLines(ByVal P() As String) As Integer
Dim S
Dim Count As Integer
For Each S In P
If Not S IsNothing Then
MsgBox(S)
Count = Count + 1
S = Nothing
End If
Next S
TestCommentedLines = Count
End Function

Target VB.NET

Public Function TestCommentedLines(ByRef P() AsString) As Integer
Dim Count As Integer
Dim S As String
ForEach S As String In P
If Not (S IsNothing) Then
MessageBox.Show(S, Application.ProductName)
Count += 1
S = Nothing
End If
Next S
Return Count
End Function

Expected VB.NET

This Issue doesn't appear on VB.NET Code.

Target C#

public int TestCommentedLines( string[] P)
{
int Count = 0;
foreach (string S in P)
{
if (S != null)
{
MessageBox.Show(S, Application.ProductName);
Count++;
//UPGRADE_NOTE: (2041) The following line was commented.
//S = null;
}
}
return Count;
}

Expected C#

public int TestCommentedLines( string[] P)
{
int Count = 0;
foreach (string S in P)
{
if (S != null)
{
MessageBox.Show(S, Application.ProductName);
Count++;
}
}
return Count;
}

API Calls are Moved

The VBUC performs some code refactoring on any of the API calls that it finds. Consolidating all those calls into new files. When that happened the original VB6 Declare API statement is commented out. This line is just left as an information reference. The recommendation is to remove this line.

For more information see API Call conversion to Platform Invoke